Remove sha1 from default features in gix-hash#2441
Conversation
Sebastian Thiel (Byron)
force-pushed
the
remove-sha-1-from-default-features
branch
from
15f0e75 to
f6fa94b
Compare
Sebastian Thiel (Byron)
force-pushed
the
remove-sha-1-from-default-features
branch
from
f6fa94b to
37d0acc
Compare
|
Thanks a lot for keeping the sha256-ball rolling! Actually this is really nice as it reveals crates with a direct relationship to I will go back into hiding until the PR comes out of draft. |
|
Quick status update: I believe I’ve now made all the follow-up changes necessary to make CI green. The last test failure seems not related to my changes as far as I can tell. I plan on updating the description soon, giving a higher-level overview of all the changes and some observations I made along the way. |
That seems likely--I just reran the one failed job and it succeeded. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6177174fdf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Review Notes
|
Sebastian Thiel (Byron)
force-pushed
the
remove-sha-1-from-default-features
branch
6 times, most recently
from
13a1efe to
63e3e6a
Compare
This way one can control which hashes are compiled in exactly, while having reasonable defaults automatically.
Sebastian Thiel (Byron)
force-pushed
the
remove-sha-1-from-default-features
branch
from
63e3e6a to
3832916
Compare
Sebastian Thiel (Byron)
merged commit e8bf096
into
GitoxideLabs:main
3 participants
feat!: remove
sha1from default features ingix-hashAdapt to
sha1not being default feature ofgix-hashMake
gixdepend ongix-hashwithsha1enabledThis PR removes
sha1fromgix-hash’s default features. It adds a featuresha1to all depending crates that did not compile anymore after the removal. Now,just checkpasses and I want to get feedback from CI to see where else I need to adapt to these changes.This PR also adds
sha1tofeaturesin the[package.metadata.docs.rs]section of all crates that now have a feature flagsha1.This PR is part of #281.